feat(mapgen-studio): pin docks between header and footer with bottom constraint, pointer-events pass-through, and LAYOUT geometry update#1619
Merged
Conversation
This was referenced Jun 12, 2026
refactor(studio): decompose App.tsx non-React corpus into feature modules and shared utilities
#1608
Merged
Merged
Merged
Owner
Author
This was referenced Jun 12, 2026
This was referenced Jun 12, 2026
Merged
mateicanavra
force-pushed
the
design/layout-geometry
branch
from
June 12, 2026 20:44
533a2f2 to
b8d88d2
Compare
mateicanavra
force-pushed
the
design/pass2-frame
branch
from
June 12, 2026 20:44
5eeea7e to
b9350a0
Compare
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/pass2-frame
to
graphite-base/1619
June 12, 2026 21:18
…der, full-height column OpenSpec mapgen-studio-layout-geometry. LAYOUT constants become the geometry authority (PANEL_WIDTH 340, EXPLORE 260 corrected, HEADER_HEIGHT now an initial estimate); AppHeader drops the stale minHeight:104 reserve (ResizeObserver stays authoritative — dead band gone, docks rise to y≈72); docks pin header→footer (pointer-events pass-through below short panels); RecipePanel max-h-full + sticky scroll-edge fade; ExplorePanel max-h-full + internal scroll. Verified: tsc, 141 tests, DOM measurements + dark screenshot on :5173. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mateicanavra
force-pushed
the
design/layout-geometry
branch
from
June 12, 2026 21:20
b8d88d2 to
d6dd4d5
Compare
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The left and right docks are now pinned between the measured header and the footer bar using a
bottomconstraint (FOOTER_HEIGHT + 2×SPACING), so panels can no longer underlap the footer on short viewports. Both docks carrypointer-events-noneand span the full header→footer column; panels restorepointer-events-autoon themselves so map interactions pass through any empty dock space.Panel widths are now driven exclusively by
LAYOUTconstants (PANEL_WIDTH340px,EXPLORE_PANEL_WIDTH260px) via inline styles, replacing the previous hardcoded arbitrary-value Tailwind width classes. Height is capped withmax-h-fullagainst the dock column rather than the oldmax-h-[calc(100vh-180px)]magic value.The
RecipePanelscroll body gains a sticky bottom gradient fade (from-popover,h-6,pointer-events-none, negative top margin) so the "more content below" affordance is always visible mid-scroll without any scroll-position JavaScript. The form wrapper carries matchingpb-6so the fade overlays only padding at full scroll, never the last field row.HEADER_HEIGHTinlayout.tsis updated to 48 and re-documented as an initial paint estimate only — theResizeObserverinAppHeaderremains the measurement authority. TheminHeightreserve previously applied to the header element is removed, as is the re-exportedHEADER_HEIGHTconstant fromAppHeader.tsx.