docs(mapgen-studio): pass-3 frame — spacing substrate repair, config surface elevation, footer console split, explore toolbar grouping, and no-hardcoded-defaults law#1625
Merged
Conversation
This was referenced Jun 12, 2026
refactor(studio): decompose App.tsx non-React corpus into feature modules and shared utilities
#1608
Merged
Merged
|
Railway preview (MapGen Studio): not provisioned for this PR. Policy (Graphite stacks): previews are created only for the top-of-stack PR by default.
Debug: |
This was referenced Jun 12, 2026
Owner
Author
This was referenced Jun 12, 2026
This was referenced Jun 12, 2026
Merged
mateicanavra
force-pushed
the
design/theme-class-sync
branch
from
June 12, 2026 20:44
24357e9 to
93c11bc
Compare
mateicanavra
force-pushed
the
design/pass3-frame
branch
from
June 12, 2026 20:44
817750c to
2f38f52
Compare
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/theme-class-sync
to
graphite-base/1625
June 12, 2026 21:30
…fig surface, console split, toolbar groups, no-hardcoded-overrides law
Grounding found the root of 'padding/margins are really bad': an unlayered
* {margin:0;padding:0} reset in index.html outranks Tailwind v4's @layer
utilities, zeroing every spacing utility app-wide. Frame + 5 strict-valid
OpenSpec changes (D0 substrate, D1 config surface, D2 footer consoles,
D3 explore toolbar groups, D4 no hard-coded defaults).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mateicanavra
force-pushed
the
design/pass3-frame
branch
from
June 12, 2026 21:32
2f38f52 to
f74dd31
Compare
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR frames Pass 3 of the Mapgen Studio redesign, establishing the design decisions, OpenSpec slices, and implementation tasks for four grounded fixes discovered during live DOM inspection.
Root cause uncovered: Every Tailwind padding and margin utility in the app has been computing to
0pxsince the Tailwind v4 migration. An unlayered* { margin: 0; padding: 0 }reset inindex.htmltakes cascade priority over all@layer utilitiesoutput, silently zeroing all spacing app-wide. A second bootstrap defect was found in the same file: the pre-paint theme script readsmapgen-studio:themefrom localStorage while the app writestheme-preference, causing a dark flash for light-theme users on every load. The spacing substrate slice (mapgen-studio-spacing-substrate) removes the unlayered reset and aligns the bootstrap key.Config surface elevation (D1): With the spacing mechanism restored, the config panel's nesting idiom is redesigned.
border-lindent ladders are replaced with a surface-elevation scheme: stage card → recessed group well (bg-background/40-class tint, subtle border, rounded, padded). Two surface tiers maximum; deeper nesting differentiates by eyebrow heading and rhythm only. Arrays unify onto the same well treatment. Form rhythm is codified in a singleFORMconstant on the 4px base: 4px within a field block, 8px between fields, 12px between groups and stage cards. Group headings move to the eyebrow tier (uppercase, muted) so field labels remain the brightest scan anchors.Footer console split (D2): The footer is restructured into two named consoles. A centered Studio console carries generation status, last-run summary, seed, reroll, auto-run, and Run. A right-docked Game console (with an identity eyebrow) carries the live Civ7 runtime chip, apply-suggestion, autoplay, Run in Game with its status/retry/diagnostics, and the save-deploy chip. Run in Game moves to the Game console because it commands the live game. Studio↔game relation cues (stale ring, Current/Stale/Previous chip) are preserved and co-located on the Game console; dirty state stays on the Studio console. The Studio console centers independently of the Game console's width.
Explore toolbar regrouping (D3): Controls are reorganized into two eyebrow-labeled clusters — VIEW (fit to view, edges overlay) and DATA (render mode, space, and conditional era/variant/overlay rows) — with consistent label-left/control-right row anatomy replacing the current zig-zag layout. The debug toggle moves to the DATA section header because
showDebugLayersfilters the data list entries, not the map rendering.Dead default-config removal (D4):
src/ui/data/defaultConfig.ts, a 330-line hand-maintained duplicate of the standard recipe's default pipeline config that the app never imports, is deleted. The two test blocks that guarded its shape are retargeted to assert againstSTANDARD_RECIPE_CONFIG, the generated artifact the app actually uses.