docs(mapgen-studio): add pass-2 design-fix frame, five OpenSpec slices (layout geometry, form hierarchy, run console, explore toolbar, first-run visibility)#1618
Merged
Conversation
This was referenced Jun 12, 2026
refactor(studio): decompose App.tsx non-React corpus into feature modules and shared utilities
#1608
Merged
Merged
Owner
Author
This was referenced Jun 12, 2026
|
Railway preview (MapGen Studio): not provisioned for this PR. Policy (Graphite stacks): previews are created only for the top-of-stack PR by default.
Debug: |
This was referenced Jun 12, 2026
This was referenced Jun 12, 2026
Merged
mateicanavra
force-pushed
the
design/pass2-frame
branch
from
June 12, 2026 20:44
5eeea7e to
b9350a0
Compare
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/a11y-fixes
to
graphite-base/1618
June 12, 2026 21:16
… OpenSpec slices User verdict on Pass 1: still squished. Reframe (constraint relaxation): chrome geometry is redesigned; control density + behavior parity stay. Frame doc with issue→change map + falsifier; .interface-design/system.md Pass-2 amendment; five strict-valid OpenSpec changes (layout-geometry, form-hierarchy, run-console, explore-toolbar, first-run-visibility). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mateicanavra
force-pushed
the
design/pass2-frame
branch
from
June 12, 2026 21:18
b9350a0 to
b9fc08b
Compare
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pass 2 — Design Fixes (visually-grounded, spec-driven)
Following a direct visual inspection of the running studio (dark, 1600×950), the Pass 1 redesign was found to still read as squished and not functionally complete. The root cause: Pass 1 interpreted "preserve as-built dimensions" as covering chrome geometry, which meant the old pre-redesign skeleton shipped under new paint. This pass relaxes that constraint — control density stays inviolate, chrome geometry is redesigned.
What's wrong and why
Nine defects were identified from live inspection and DOM measurement, resolving to five fix slices:
AppHeaderforcesminHeight: 104even though a ResizeObserver already measures the real header height; the recipe panel caps itself with a magiccalc(100vh-180px)that cuts content mid-sentence with no scroll affordance.text-muted-foreground), making the form a wall of indistinguishable gray. Separately, the field template mounts ~40 emptyrole="alert"live regions because it gates on the always-truthyerrorselement rather thanrawErrors?.length.Changes introduced
Design system amendment (
system.md,pass-2-design-fixes.md,00-GOAL.md): documents the constraint relaxation, the nine observed issues mapped to five slices, and a falsifier — if the chrome still reads squished after C1+C2, the floating-panel paradigm itself is the problem and a structural relayout becomes the next frame.C1 —
mapgen-studio-layout-geometry:PANEL_WIDTH280 → 340;EXPLORE_PANEL_WIDTHcorrected to 260;HEADER_HEIGHTre-stated as the ResizeObserver seed (≈48), not a reserve.AppHeaderdrops the staticminHeight. Docks gain abottomconstraint so panels span the full header→footer column.RecipePanelreplaces the magic height cap withmax-h-full;ExplorePanelgains internal scrolling. A sticky token-driven bottom fade replaces hard scroll cuts.C2 —
mapgen-studio-form-hierarchy: Field labels move totext-foregroundmedium weight in bothrjsfTemplates.tsxand the hand-rolled field set; descriptions stay muted. The error live region gates onrawErrors?.length— zero emptyrole="alert"nodes on a pristine form, with theid="${id}__error"association contract preserved for fields that do have errors.C3 —
mapgen-studio-run-console: The recipe panel's Run button is removed; its footer row becomes Save & Deploy only. The dirty-config ring emphasis moves to the footer Run.formatResourceModereturns full words ("Balanced", etc.).C4 —
mapgen-studio-explore-toolbar: Render and Space option clusters become bounded segmented controls (bg-input-backgroundcontainer, active option lifted one surface tier). Independent toggles (fit, edges, debug) are left unwrapped.C5 —
mapgen-studio-first-run-visibility: Diagnosis is required before code — root cause (camera never fitted to first manifest bounds vs. inherently invisible default layer) recorded indesign.md. Fix triggers the existing fit-to-view path when a run completes and the camera has never been positioned over generated matter; a user-positioned camera is never auto-refit on subsequent runs.Each slice closes only with visual proof from the running app (screenshot or measured DOM delta, dark and light where theming is implicated).