docs(mapgen-studio): add Pass 5 design-fixes spec (toolbar architecture v2, tile orientation, canvas affordances)#1635
Merged
Merged
Conversation
This was referenced Jun 12, 2026
Merged
refactor(studio): decompose App.tsx non-React corpus into feature modules and shared utilities
#1608
Merged
Merged
|
Railway preview (MapGen Studio): not provisioned for this PR. Policy (Graphite stacks): previews are created only for the top-of-stack PR by default.
Debug: |
This was referenced Jun 12, 2026
This was referenced Jun 12, 2026
Merged
mateicanavra
force-pushed
the
design/config-collapse
branch
from
June 12, 2026 20:44
cdbecef to
44a8e66
Compare
mateicanavra
force-pushed
the
design/pass5-frame
branch
from
June 12, 2026 20:44
aa8b3dd to
25fdaa5
Compare
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/config-collapse
to
graphite-base/1635
June 12, 2026 21:50
…entation, canvas affordances
mateicanavra
force-pushed
the
design/pass5-frame
branch
from
June 12, 2026 21:52
25fdaa5 to
cb79c21
Compare
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This document establishes the fifth design pass on the mapgen studio redesign, covering five discrete changes.
X1 — Toolbar Architecture v2 restructures the top/bottom bar split into a clear Game vs World/Map zoning. The top bar becomes the Game toolbar, consolidating the saved-config selector, live Civ7 status, autoplay, Explore, save-deploy, retry/diagnostics, Run in Game, and an icon-only setup disclosure at the far right. The bottom bar becomes the World/Map console, holding studio status, History, Size, Players, Resources, Seed, reroll, auto-run, and Run. Last-run stats collapse into a History icon button with a hover tooltip. Resources moves to the bottom bar as a map setting, and the setup dropdown is scoped to pure Civ7 game setup (Leader, Civ, Difficulty, Speed). The History button doubles as copy-seed to preserve that affordance.
X2 — Grid Icon fixes a missing glyph in
ViewControls.tsxwhere an empty<div>sits in place of the grid toggle icon, replacing it with theGrid3x3lucide glyph. A categorical sweep confirmed no other empty icon placeholders exist in the codebase.X3 — Tile Orientation corrects a 30° rotation bug where
render.tsapplies pointy-top polygon math to odd-Q (flat-top) hex layouts. The fix switches to flat-top vertex calculation for odd-Q tiles and verifies the associated center-spacing and bounds math. This pass also standardizes the tile-mesh contract across all visualizations: borders must be legible on any background, unfilled tiles render nothing, and the optional background grid follows a single consistent treatment.X4 — White Flash on Refresh investigates a flash that survives the existing
index.htmldark-mode guard. The approach uses an earliest-inline-script sampler logging computed background colors and canvas presence into sessionStorage over the first ~1s of load, targeting three suspects: WebGL canvas white clear before first deck draw, an unstyledhtmlelement, or Vite injecting CSS via JS after first paint. The fix follows once the culprit is identified.X5 — Pre-run Cursor suppresses the deck controller and grab cursor before a manifest exists, since panning pre-run moves nothing visible and reads as broken. Post-run behavior is unchanged.